Changes to using f-string throughout gophish-export: c355e6f
Adds a function to check if the assessment exists function within GoPhish before attempting to export: b5bcff8
Creates a pytest for the new function and improves the clarity of calls within the test_tools.py script: 5a09d24
Fixes formatting of the JSON file that is output by the script. Prior the output was two lists saved to a json file. With the changes, two keys are created, "campaigns" and "users", for the lists to sit under. The change also makes writing tests for import_users and campaignControl becomes much nicer. e7bc720
Creates a pytest for import_users: ca71b7f
Merged updates from upstream: a541f96
Housekeeping on docstrings, comments, and typos found within the associated scripts: c4dd013, 4020168, 63eb08e, 88a01c1
💭 Motivation and Context
The main focus of this update was to add the assessment exists check so a user would not receive an empty data file when the script is run. Additional changes were made at this time to update formatting and improve testing.
🧪 Testing
I conducted manual tests to ensure a correct assessment id results in a data file while an incorrect assessment id generates the expected error.
📷 Screenshots (if appropriate)
🚥 Types of Changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (causes existing functionality to change)
✅ Checklist
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
dav3r
commented
4 years ago
🗣 Description
This PR does the following:
gophish-export: c355e6ftest_tools.pyscript: 5a09d24import_usersandcampaignControlbecomes much nicer. e7bc720import_users: ca71b7f💭 Motivation and Context
The main focus of this update was to add the assessment exists check so a user would not receive an empty data file when the script is run. Additional changes were made at this time to update formatting and improve testing.
🧪 Testing
I conducted manual tests to ensure a correct assessment id results in a data file while an incorrect assessment id generates the expected error.
📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist