Inconsistent use of write_property/write-property - Githubissues

cisagov / icsnpp-bacnet

Zeek BACnet Parser - CISA ICSNPP

BSD 3-Clause "New" or "Revised" License

15 stars 11 forks source link

Inconsistent use of write_property/write-property #17

Closed keithjjones closed 1 year ago

keithjjones commented 1 year ago

This has a dash:

https://github.com/cisagov/icsnpp-bacnet/blob/646032358b3aa994aeab8fa7acb0fe1d86d616f7/scripts/icsnpp/bacnet/main.zeek#L396

While this has an underscore:

https://github.com/cisagov/icsnpp-bacnet/blob/35243a1a3e821216df693761bc67ef1b7f3203f5/scripts/consts.zeek#L266

My logs have both dashes and underscores. Shouldn't they be all underscore?

keithjjones commented 1 year ago

Nevermind - I see why they are different now.