search

cisagov / icsnpp-bacnet

Zeek BACnet Parser - CISA ICSNPP
BSD 3-Clause "New" or "Revised" License
15 stars 11 forks source link

Exception when processing bacnet_services.pcap #37

Closed kkvarfordt closed 3 months ago

kkvarfordt commented 3 months ago

🐛 Summary

The following exception is thrown when processing the bacnet_services.pcap binpac exception: out_of_bound: NPU_Message: 3 > 1

To reproduce

Steps to reproduce the behavior:

  1. Modify BACNET.cc method BACNET_Analyzer::DeliverPacket to include a printf statement with in the catch ( cont binpac::Exception& e) code block e.g. printf("EXCEPTION ==> %s\n", e.c_msg());
  2. make clean all
  3. zeek -Cr bacnet_services.pcap icsnpp/bacnet

Expected behavior

A "clean" run - no exception thrown.

kkvarfordt commented 3 months ago

Fixed. See PR #41