Multiple object types, but only one gets logged. (Issue 30) - Githubissues

cisagov / icsnpp-bacnet

Zeek BACnet Parser - CISA ICSNPP

BSD 3-Clause "New" or "Revised" License

15 stars 11 forks source link

Multiple object types, but only one gets logged. (Issue 30) #38

Closed kkvarfordt closed 3 months ago

kkvarfordt commented 3 months ago

🗣 Description

When there are multiple object types in one packet, only one gets logged. See issue #30 for details.

💭 Motivation and context

Modified the code to log the device_id_type and the device_id_number fields which were being parsed/analyzed, but not logged.

🧪 Testing

Ran the parser using the test.pcap attached to issue #30 as input and verified the device_id and device_id_number fields were logged accordingly.