Closed keithjjones closed 2 years ago
Great, would you please add that same check to the other location in that file where is_num is used?
Great, would you please add that same check to the other location in that file where is_num is used?
Absolutely! Committed.
๐ฃ Description
is_num("") evaluates to True, but for our cases it needs to be false because we do a to_count() later.
๐ญ Motivation and context
Because it was a bug in some pcaps I tested.
๐งช Testing
There were no tests for me to hook into.
โ Pre-approval checklist
โ Pre-merge checklist
โ Post-merge checklist