cisagov / icsnpp-bacnet

Zeek BACnet Parser - CISA ICSNPP
BSD 3-Clause "New" or "Revised" License
15 stars 11 forks source link

Add an empty string check because is_num("") == T. #7

Closed keithjjones closed 2 years ago

keithjjones commented 2 years ago

๐Ÿ—ฃ Description

is_num("") evaluates to True, but for our cases it needs to be false because we do a to_count() later.

๐Ÿ’ญ Motivation and context

Because it was a bug in some pcaps I tested.

๐Ÿงช Testing

There were no tests for me to hook into.

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist

mmguero commented 2 years ago

Great, would you please add that same check to the other location in that file where is_num is used?

keithjjones commented 2 years ago

Great, would you please add that same check to the other location in that file where is_num is used?

Absolutely! Committed.