search

cisagov / manage.get.gov

A Django-based domain name registrar that interfaces with an EPP registry
https://get.gov
Other
60 stars 18 forks source link

Update django-fsm to v3 and fix breaking changes #2060

Open abroddrick opened 7 months ago

abroddrick commented 7 months ago

Issue description

The django-fsm package released version 3 which is a breaking change and requires a different implementation. In fact, it is no longer going to be called django-fsm and is viewflow. To avoid code debt we should update to the newest version of django-fsm which will require changing how we set FSM state transitions on models

Acceptance criteria

Additional context

link to django-fsm/ viewflow's github for documentation that will help with updating. They have instructions on what to migrate and how.

Links to other issues

No response

PaulKuykendall commented 7 months ago

@h-m-f-t - is interested in the value of making this change now. Leaving in NEW state for now, until Alysia gets back.

PaulKuykendall commented 7 months ago

Currently, we are on a solid version, but it's no longer being updated. This is not urgent, but needs to be done eventually so that we get current for the next few years of updates.

katypies commented 3 months ago

Looks like Viewflow is being actively updated - I wonder whether there's some additional urgency to avoid getting so far behind that we have more significant effort required to get updated, and/or if there become security concerns with not updating.

@abroddrick would like to get a sense of current status of Viewflow and whether we need to prioritize this update.

h-m-f-t commented 3 months ago

@abroddrick is there a more-ideal time to tackle this, or is when not really material?

h-m-f-t commented 1 month ago

@abroddrick is there a more-ideal time to tackle this, or is when not really material?

I'd welcome your feedback on this, @abroddrick.