Open vickyszuchin opened 4 months ago
Per action item from eng huddle.
https://github.com/weather-gov/weather.gov/pull/279#issuecomment-1759959083 has an interesting process.
@abroddrick - please wordsmith this and move to Ready at your discretion.
Already did!
Hey all! Just dropping by to mention that I created a ticket to synthesize the accessibility survey findings that may influence some updates made to the PR checklist template as part of this ticket.
cc @gabydisarli @Katherine-Osos
During our design sync on May 21st, we discussed introducing a new process for how we'll track when issues have bypassed the design phase. We decided that we should add an item to the PR checklist that has something along the lines of:
check with design to make sure the work to update the figma and content docs is documented (should only apply to issues with the "design-artifact-update" label.
cc: @vickyszuchin
I raised this higher in the backlog.
Issue description
Shorten PR checklist template. Review checklist and identify elements for removal to streamline the template for efficiency. However, we want
Acceptance criteria
Additional context
When adding the PR review section to our readmes, this is to preserve our current best checklist for future developers that may onboard at another time. That said, you don't need repeat all the steps that duplicate for original developer, design reviewer and design reviewer Please wait until additional engineers/devs have onboarded, approximately July 2024.
Links to other issues