cisagov / manage.get.gov

A Django-based domain name registrar used by the .gov domain to communicate with an EPP registry
https://get.gov
Other
57 stars 17 forks source link

Shorten PR checklist template #2140

Open vickyszuchin opened 4 months ago

vickyszuchin commented 4 months ago

Issue description

Shorten PR checklist template. Review checklist and identify elements for removal to streamline the template for efficiency. However, we want

Acceptance criteria

Additional context

When adding the PR review section to our readmes, this is to preserve our current best checklist for future developers that may onboard at another time. That said, you don't need repeat all the steps that duplicate for original developer, design reviewer and design reviewer Please wait until additional engineers/devs have onboarded, approximately July 2024.

Links to other issues

vickyszuchin commented 4 months ago

Per action item from eng huddle.

PaulKuykendall commented 4 months ago

https://github.com/weather-gov/weather.gov/pull/279#issuecomment-1759959083 has an interesting process.

PaulKuykendall commented 4 months ago

@abroddrick - please wordsmith this and move to Ready at your discretion.

abroddrick commented 4 months ago

Already did!

rileyorr commented 3 months ago

Hey all! Just dropping by to mention that I created a ticket to synthesize the accessibility survey findings that may influence some updates made to the PR checklist template as part of this ticket.

cc @gabydisarli @Katherine-Osos

gabydisarli commented 3 months ago

During our design sync on May 21st, we discussed introducing a new process for how we'll track when issues have bypassed the design phase. We decided that we should add an item to the PR checklist that has something along the lines of:

check with design to make sure the work to update the figma and content docs is documented (should only apply to issues with the "design-artifact-update" label.

cc: @vickyszuchin

h-m-f-t commented 3 months ago

I raised this higher in the backlog.