Closed dave-kennedy-ecs closed 4 days ago
🥳 Successfully deployed to developer sandbox dk.
Hi @dave-kennedy-ecs I'll be doing your design review :)
🥳 Successfully deployed to developer sandbox dk.
🥳 Successfully deployed to developer sandbox dk.
🥳 Successfully deployed to developer sandbox dk.
Ticket
Resolves #2320
Changes
Context for reviewers
Setup
Test the following workflows: 1) Attempt to access the home page with a user logged in by IAL1 but has incomplete info (no title or phone). After completing the form and clicking Save, user should have option to manage domains 2) Attempt to access the /request/ page with a user logged in by IAL1 but has incomplete info (no title or phone). After completing the form and clicking Save, user should have an additional button to return to request. 3) Attempt to access the home page with a user logged in by IAL2 (invited user) but has incomplete info (no title or phone). After completing the user-profile form and clicking Save, user should have option to manage domains 4) Attempt to access the /request/ page with a user logged in by IAL2 (invited user) but has incomplete info (no title or phone). After completing the user-profile form and clicking Save, user should have the option to return to domain request. 5) From home page, with a completed user, Add a new domain request, then click the link on the intro page to update your profile. After updating the profile, you should have an option to return to your request.
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
[ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
[ ] Checked keyboard navigability
[ ] Meets all designs and user flows provided by design/product
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
[ ] Checked keyboard navigability
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Screenshots