search

cisagov / manage.get.gov

A Django-based domain name registrar used by the .gov domain to communicate with an EPP registry
https://get.gov
Other
53 stars 14 forks source link

Update domain_invitation_description.html to give better direction to analysts #2344

Open h-m-f-t opened 1 week ago

h-m-f-t commented 1 week ago

The table description can be improved to give analysts better context in-platform. This change makes an attempt.

h-m-f-t commented 1 week ago

cc: @Katherine-Osos, feedback welcome. When this lands, let's update the Google Doc.

h-m-f-t commented 1 week ago

Thanks, Zander! I was definitely taking a stab in the dark and appreciate your feedback.

zandercymatics commented 4 days ago

@h-m-f-t Looks like it worked! There is just one more test failure on test_get_filters. The test is literally just counting the number of times the word "invited" appears on the page. Because your new text has the word "invited", its tripping up because now its finding 5 instances of the word rather than 4.

Basically the line I've outlined in the test_admin.py file would need to change count=4 to count=5 image

(As a side note, I think we should change that test down the line - that isn't really all that useful cc @abroddrick for thoughts)