Closed erinysong closed 4 days ago
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
🥳 Successfully deployed to developer sandbox es.
Conditionally approving. Based on Dave's comments, it seems like we don't need the export on the Suborg and domain group tables yet, so I would just remove those until we are ready to export portfolio
Sounds good! Updated the PR to remove references to the Resource class in our added admin classes
Ticket
Resolves #2299
Changes
Context for reviewers
Setup
Go to getgov-es admin page and navigate to DomainGroup and Suborganization pages. You should be able to create, view, update, and delete any entries in the DomainGroup and Suborganization tables. DomainGroup table
Suborganization table
DomainGroup and Suborganization models should not be accessible on analyst account
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
[ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
[ ] Checked keyboard navigability
[ ] Meets all designs and user flows provided by design/product
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
[ ] Checked keyboard navigability
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Screenshots