Issue #2274: removed data calculation from renew_domain DJA function [BOB]

[dave-kennedy-ecs]

Ticket

Resolves #2274

Changes

• Removed date calculation on renew_domain function in django admin
• Set renew_domain to renew domain 1 year from today
• Updated modal to not display an estimated renew date

Context for reviewers

Navigate to django admin. Select a domain. Click the Extend expiration date link in the upper right of the change form. Confirm the update. Verify that the new expiration date is one year from today

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

• [x] Met the acceptance criteria, or will meet them in a subsequent PR
• [x] Created/modified automated tests
• [x] Added at least 2 developers as PR reviewers (only 1 will need to approve)
• [x] Messaged on Slack or in standup to notify the team that a PR is ready for review
• [ ] Changes to “how we do things” are documented in READMEs and or onboarding guide
• [ ] If any model was updated to modify/add/delete columns, makemigrations was ran and the associated migrations file has been commited.

Ensured code standards are met (Original Developer)

• [ ] All new functions and methods are commented using plain language
• [ ] Did dependency updates in Pipfile also get changed in requirements.txt?
• [ ] Interactions with external systems are wrapped in try/except
• [ ] Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

• [ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
• [ ] Checked keyboard navigability
• [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
• [ ] Add at least 1 designer as PR reviewer

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

• [ ] Pulled this branch locally and tested it
• [ ] Reviewed this code and left comments
• [ ] Checked that all code is adequately covered by tests
• [ ] Made it clear which comments need to be addressed before this work is merged
• [ ] If any model was updated to modify/add/delete columns, makemigrations was ran and the associated migrations file has been commited.

Ensured code standards are met (Code reviewer)

• [ ] All new functions and methods are commented using plain language
• [ ] Interactions with external systems are wrapped in try/except
• [ ] Error handling exists for unusual or missing values
• [ ] (Rarely needed) Did dependency updates in Pipfile also get changed in requirements.txt?

Validated user-facing changes as a developer

• [ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing

• [ ] Checked keyboard navigability

• [ ] Meets all designs and user flows provided by design/product

• [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

• [ ] Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)

  • [ ] Chrome
  • [ ] Microsoft Edge
  • [ ] FireFox
  • [ ] Safari

• [ ] (Rarely needed) Tested as both an analyst and applicant user

Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist

As a designer reviewer, I have

Verified that the changes match the design intention

• [ ] Checked that the design translated visually
• [ ] Checked behavior
• [ ] Checked different states (empty, one, some, error)
• [ ] Checked for landmarks, page heading structure, and links
• [ ] Tried to break the intended flow

Validated user-facing changes as a designer

• [ ] Checked keyboard navigability

• [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

• [ ] Tested with multiple browsers (check off which ones were used)

  • [ ] Chrome
  • [ ] Microsoft Edge
  • [ ] FireFox
  • [ ] Safari

• [ ] (Rarely needed) Tested as both an analyst and applicant user

Screenshots

[github-actions[bot]]

🥳 Successfully deployed to developer sandbox bob.

[github-actions[bot]]

🥳 Successfully deployed to developer sandbox bob.

[dave-kennedy-ecs]

I tried extending the expiration date for the domain "ago-song-process.gov", but no matter how many times I try, the expiration date stays the same (June 25, 2025). See screenshot:

The ticket indicated that the renew function should always renew to 1 year from today's date.

[kristinacyin]

I tried extending the expiration date for the domain "ago-song-process.gov", but no matter how many times I try, the expiration date stays the same (June 25, 2025). See screenshot:

The ticket indicated that the renew function should always renew to 1 year from today's date.

Got it, that makes sense. Would it be possible to edit the warning message, as indicated in my original comment? Thank you! @dave-kennedy-ecs

[zandercymatics]

The ticket indicated that the renew function should always renew to 1 year from today's date.

(Comment / not my domain so take it with a grain of salt) I would think that, from a UX perspective, we should probably disable the button in some way, not show it, or throw an error once that condition is hit

[github-actions[bot]]

🥳 Successfully deployed to developer sandbox bob.

[kristinacyin]

Also, FYI it worked before but after logging back in, I'm getting a server error when I try to see the details of a domain (click on a domain name in the Domains table). Is it because of the waffle flag?

[rachidatecs]

Also, FYI it worked before but after logging back in, I'm getting a server error when I try to see the details of a domain (click on a domain name in the Domains table). Is it because of the waffle flag?

Still seeing an issue @kristinacyin?

[kristinacyin]

Also, FYI it worked before but after logging back in, I'm getting a server error when I try to see the details of a domain (click on a domain name in the Domains table). Is it because of the waffle flag?

Still seeing an issue @kristinacyin?

It's fine now!