Closed zandercymatics closed 20 hours ago
🥳 Successfully deployed to developer sandbox za.
@CocoByte Should be on getgov-hotgov!
🥳 Successfully deployed to developer sandbox za.
🥳 Successfully deployed to developer sandbox za.
🥳 Successfully deployed to developer sandbox za.
🥳 Successfully deployed to developer sandbox za.
🥳 Successfully deployed to developer sandbox za.
@abroddrick While unrelated, it looks like that bug is coming from some failing js in our get-gov-admin.js file.
Since select-2 uses AJAX to grab its data, this is causing a fail condition on the creator field when you try to access it. I can only repliclate this locally - I do not entirely understand why but it likely is just script load order. I've include some error handling in the failing area of the script (it was missing that anyway)
🥳 Successfully deployed to developer sandbox za.
Ticket
Resolves #2157
Changes
Context for reviewers
This PR will send an email to the domain request creator rather than the submitter only if the profile feature flag is enabled
Setup
For all of the steps below, make sure both the creator and submitter have emails that you are in control of
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
[ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
[ ] Checked keyboard navigability
[ ] Meets all designs and user flows provided by design/product
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
[ ] Checked keyboard navigability
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Screenshots