Open therealslimhsiehdy opened 3 days ago
🥳 Successfully deployed to developer sandbox rh.
🥳 Successfully deployed to developer sandbox rh.
🥳 Successfully deployed to developer sandbox rh.
🥳 Successfully deployed to developer sandbox rh.
@CocoByte I think this partially interacts or at least is related to your senior official ticket! Just pinging you for awareness since you have an open PR on this
🥳 Successfully deployed to developer sandbox rh.
Ticket
Resolves #2258
Changes
Authorizing Official
toSenior Official
everywhere, including unit tests and in file names (you'll see it renamed fromao
toso
)Context for reviewers
Setup
senior_official
in the URL routes,Senior Official
in the request texts and in/admin
and moreCode Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
[ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
[ ] Checked keyboard navigability
[ ] Meets all designs and user flows provided by design/product
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
[ ] Checked keyboard navigability
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Screenshots