search

cisagov / manage.get.gov

A Django-based domain name registrar used by the .gov domain to communicate with an EPP registry
https://get.gov
Other
58 stars 18 forks source link

Add date email was sent to Action needed email #2838

Open gabydisarli opened 1 week ago

gabydisarli commented 1 week ago

Issue Description

During design review of PR 2713 to Refactor the action needed email implementation, I suggested we should add the date in parenthesis after the Email label when the email has been sent. Because the initial design was too buggy, we'd switched to a simpler field design, but it lacks some of the indicators we had in the old design. We need further indicators to tell analysts that the email they're viewing has been sent. Right now, the email switches from "Email" to "Email sent to creator" after the analyst has clicked saved. Having a date will offer another indicator that this email was sent.

Acceptance Criteria

See original discussion in the PR comment linked below. Originally posted by @rachidatecs in https://github.com/cisagov/manage.get.gov/issues/2713#issuecomment-2364120356

See screenshot for example

Screenshot 2024-09-23 at 11 37 28 AM
katypies commented 1 week ago

@gabydisarli - if another email is sent, should the date be updated to be the latest date something was sent to the creator?

zandercymatics commented 1 week ago

@gabydisarli I would recommend adding a screenshot or two - but this looks good to me, at least. Want me to?

gabydisarli commented 6 days ago

@katypies Yes, I think it should update if another email is sent.

gabydisarli commented 6 days ago

@zandercymatics looks good to you?

zandercymatics commented 6 days ago

@gabydisarli Looks great!