cisagov / manage.get.gov

A Django-based domain name registrar that interfaces with an EPP registry
https://get.gov
Other
60 stars 18 forks source link

Django admin: Update portfolio fields on Domain Information #2867

Open zandercymatics opened 1 month ago

zandercymatics commented 1 month ago

Issue description

In #2934 we updated the layout of Domain Requests for Org model and non-org model requests, and added in conditional logic so that fields that were only relevant to the org model requests disappeared for non org model requests and visa versa. Meanwhile, in #2852 we updated the domain requests so the the filters and domain request table in admin also pull from the portfolio when appropriate and the domain request otherwise. We should now copy what was done for domain requests so domain info has the same logic and layout and ensure that domain (which uses domaininfo inline) receives those layout changes appropriately.

The goal of this ticket should be to make sure all places where we display domain info data now pulls from portfolio when appropriate on the change form views of admin

Acceptance criteria

Domain Information

Additional context

Regarding the series of dashes AC, your solution should keep select2 (or at least replace it) as it offers us a performance boost and a search bar.

Refer PR for #2934 so that it is easy to do this change.

Links to other issues

katypies commented 1 month ago

@abroddrick to review this to see if some items need to be split out for domain requests.

abroddrick commented 1 month ago

Removed domain request items

h-m-f-t commented 1 month ago

Right now, this issue and #2826 are both planned next sprint (57). This issue appears to touch select2 which we're proposing be in-sourced in 2826. Paging @abroddrick for awareness and whether these two should be sequenced in a certain order.