cisagov / pe-reports

Automated process to build and distribute Posture & Exposure Reports' bi-weekly to customers.
Creative Commons Zero v1.0 Universal
17 stars 5 forks source link

Replace Get_orgs #640

Closed edujosemena closed 11 months ago

edujosemena commented 11 months ago

Fixes #639

🗣 Description

For preventing sql injection errors the team is focusing on creating more API endpoints to interact with instead of using direct API calls. To get this going we need to modify the get_orgs function in db_query to get the data from the api endpoint in crossfeed rather than directly use TSQL.

Implementation notes

🧪 Testing

API endpoint is successfully called using the requests library

✅ Pre-approval checklist

coveralls commented 11 months ago

Coverage Status

coverage: 26.737% (+0.1%) from 26.628% when pulling 1713f77623e46206fc4f273282b3b3b776862abf on EM-get-org-api into 818ecce1098e2763eeb072b962d17031553ee959 on develop.

dav3r commented 11 months ago

@edujosemena You should ensure that you have done all of the items in the "Pre-approval checklist" (and checked the checkboxes) before requesting approval of this PR. You may delete any that don't apply, e.g. if you have no TODO items, you may remove the "All future TODOs are captured in issues, which are referenced in code comments." item.