Deep Check for Any Remaining TSQL

[arng4108]

💡 Summary

We need to go through the entire report run process and double check that there are no lingering TSQL calls in the code.

Motivation and context

The main purpose behind switching to API endpoints is to completely discontinue the use of potentially insecure TSQL calls.

Implementation notes

• The PE scan code will need to be checked
• The PE report gen process will need to be checked
• The PE mailing process will need to be checked
• Will involve lots of code tracing and review

Progress:

• All 10 PE scans have been checked, found 14 TSQL calls that will need to be converted to API endpoints
• All PE report generation code has been checked, found 3 TSQL calls that will need to be converted to API
• All PE report encryption code has been checked, found 1 TSQL call that will need to be converted to API
• All PE report mailing code has been checked, found 0 TSQL calls that will need to be converted to API
• All PE ASM sync code has been checked, found 32 TSQL calls that will need to be converted to API

After all code has been checked, this issue will be closed and each TSQL to API conversion will be tracked individually. One github issue per TSQL function to API endpoint conversion.

Acceptance criteria

• [X] PE scans have been checked for active TSQL calls
• [X] PE ASM sync code has been checked for active TSQL calls
• [X] PE report generation has been checked for active TSQL calls
• [X] PE report encryption has been checked for active TSQL calls
• [X] PE report mailing has been checked for active TSQL calls

[arng4108]

PE scan, asm sync, report generation, report encryption, and report mailing code has been checked for remaining TSQL queries. Now that the lingering TSQL functions have been identified, each conversion from TSQL to API endpoint will be tracked using separate, individual github issues