cisagov / pe-reports

Automated process to build and distribute Posture & Exposure Reports' bi-weekly to customers.

Creative Commons Zero v1.0 Universal

17 stars 5 forks source link

Fix Root Domain/IP/CIDR Count Problem with the PE PDF Report #697

Closed arng4108 closed 6 months ago

arng4108 commented 6 months ago

💡 Summary

A stakeholder contacted us about a problem with their PDF report where the root domain, CIDR, and IP count were incorrect:

The reported IP/CIDR count on their ASM summary had a sudden significant drop starting at 2023-10-31.
The reported root domain count on their ASM summary did not match the root domain count in the attached .xlsx/.json data.

Motivation and context

IP/CIDR count should not be that low, and should remain relatively the same, only fluctuating a little bit.

Root domain count in the ASM summary should match the attached data.

Implementation notes

Need to identify source of problem
Need to implement solution
Need to test to see if that fixed the problem

Acceptance criteria

[X] Root domain count issue fixed
[X] IP/CIDR count issue fixed

arng4108 commented 6 months ago

The sources of the root domain count and IP/CIDR count issues have been identified. The root domain count problem was caused by the vw_orgs_total_domains view missing the enumerate_subs=True filter. The IP/CIDR count problem was caused by the ASM sync script not being ran every report period, combined with the fact that VS changed the password to their database.