cisagov / scanner

Automated pshtt, trustymail, and sslyze scanning
Creative Commons Zero v1.0 Universal
24 stars 5 forks source link

Skeletonize #63

Closed jsf9k closed 1 year ago

jsf9k commented 2 years ago

๐Ÿ—ฃ Description

This pull request skeletonizes the repo against cisagov/skeleton-docker.

๐Ÿ’ญ Motivation and context

All of our repos that are still being used should be based on a skeleton repo.

๐Ÿงช Testing

All automated tests pass.

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist

jsf9k commented 1 year ago

@felddy and I asked an AI to compose a ballad about @mcdonnnj's code reviews, and this is what we got:

In a dark and dreary office
Sits a man named Nick
He reviews code with utmost caution
But oh how it makes us sick

With every pull request he scrutinizes
His feedback is always precise
But the team's patience wears thin
As we wait for his advise

The deadline looms closer still
But Nick remains a stick in the mud
Our managers, they do plead
For him to speed things up

But still he plods along
As slow as a summer's day
And when the project's finally done
We all just want to say

Nick, oh Nick, you try our patience
With your nitpicking ways
But in the end, the code is better
For all the time you spend in a daze

So here's to you, dear Nick
For making our code shine
But please, for the love of all that's holy
Pick up the pace just this one time
h-m-f-t commented 1 year ago

:clap:

jsf9k commented 1 year ago

Please update to the latest version (0.6.9) of pshtt for consistency since you have updated the corresponding lambda:

This PR is only to skeletonize the repo. As soon as this one is merged I will create a separate PR that simply updates the version of pshtt that is installed.