cisagov / skeleton-ansible-role

A skeleton project for quickly getting a new cisagov Ansible role started.
Creative Commons Zero v1.0 Universal
7 stars 6 forks source link

Use the full path for source Docker images #176

Closed mcdonnnj closed 8 months ago

mcdonnnj commented 8 months ago

๐Ÿ—ฃ Description

This pull request updates the configuration to use the full path (including registry) for the Docker images used for testing.

[!NOTE] This branch is built off of #175 and is intended to be merged along with that PR. Given the changes in that PR it seemed like the easiest approach to avoid major conflicts.

๐Ÿ’ญ Motivation and context

Using the full image name will ensure that we pull exactly the image we mean to when testing. This is important because some operating systems (such as Red Hat Enterprise Linux) are configured with a default registry other than Docker Hub. This is also consistent with https://github.com/cisagov/skeleton-docker/pull/187.

๐Ÿงช Testing

Automated tests pass.

โœ… Pre-approval checklist