cisagov / skeleton-ansible-role

A skeleton project for quickly getting a new cisagov Ansible role started.
Creative Commons Zero v1.0 Universal
7 stars 6 forks source link

Remove explicit requirement for `community.docker` from the Molecule requirements #195

Open mcdonnnj opened 5 months ago

mcdonnnj commented 5 months ago

💡 Summary

This requirement is added in #196 and should be removed when no longer needed.

Motivation and context

This requirement is a way for us to a get a version of the community.docker collection that is compatible with requests version 2.32.0 and newer. The version available from the latest ansible release is not new enough and we are still waiting on the merge of https://github.com/ansible-community/molecule-plugins/pull/257 to force molecule-plugins to require a compatible version for the Docker driver. We would also be able to skirt around this issue with the release of Ansible 9.7 next month (June of 2024) as it should contain the newer version of the community.docker collection.

Acceptance criteria

How do we know when this work is done?

jsf9k commented 5 months ago

docker/docker-py#3257 has been merged and a new version has been released. I think this means we can now revert or modify the requirement added in #196.

mcdonnnj commented 5 months ago

docker/docker-py#3257 has been merged and a new version has been released. I think this means we can now revert or modify the requirement added in #196.

I'm unclear on what you're saying here. That PR was merged and a new release was cut almost a week before this issue was created. The community.docker project vendors docker-py so we explicitly need the fixes made to this vendored code in 3.10.1 and 3.10.2. The current version of Ansible per our version pinning is 9.6.1, which only has community.docker 3.10.1 (likely because this is an emergency bugfix release for the yanked 9.6.0 release). Theoretically this issue can also be resolved if a newer version of Ansible that we are pinned around includes community.docker >=3.10.2.