Add go packages for pre-commit

cisagov / skeleton-generic

A generic skeleton project for quickly getting a new cisagov project started.

Creative Commons Zero v1.0 Universal

13 stars 11 forks source link

Add go packages for pre-commit #138

Closed jasonodoom closed 9 months ago

jasonodoom commented 11 months ago

🗣 Description

This PR includes go packages needed to run our Go hooks.

💭 Motivation and context

The current cisagov/skeleton-golang-package build is failing because some of these packages such as gosec and go-critic are missing. These packages are needed for pre-commit. As such, I've added them to the build workflow.

🧪 Testing

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[x] Revert to using the develop branch of cisagov/setup-env-github-action once cisagov/setup-env-github-action#65 is merged.

jsf9k commented 11 months ago

@jasonodoom - Please note that I added commit ddbf6f7, as well an additional checklist item to the PR description. The GitHub Actions workflow is still failing, but for a different reason now.

jsf9k commented 11 months ago

@jasonodoom - Nick's GitHub handle is @mcdonnnj, not @mcdonnj. You need to fix that in commit 7635b24.

jsf9k commented 11 months ago

@jasonodoom - Nick's GitHub handle is @mcdonnnj, not @mcdonnj. You need to fix that in commit 7635b24.

Now you've combined commit 63fb67e into 52d369c as well, so you'll need to mention that you're sorting alphabetically into that commit message. (It would have been better to leave those as separate commits.)

jasonodoom commented 11 months ago

@jasonodoom - Nick's GitHub handle is @mcdonnnj, not @mcdonnj. You need to fix that in commit 7635b24.

Now you've combined commit 63fb67e into 52d369c as well, so you'll need to mention that you're sorting alphabetically into that commit message. (It would have been better to leave those as separate commits.)

You're right. I usually don't combine this many changes in one commit. I just chose the easiest option. 😅 I won't next time. Fixed in https://github.com/cisagov/skeleton-generic/pull/138/commits/1e7cb4f721542b260680ee51d4cd75126da0a979

jsf9k commented 10 months ago

This looks good to me now. Just remember to revert commit ddbf6f7 once cisagov/setup-env-github-action#65 is merged.

I took care of this in commit 98d3d3f.