Closed mcdonnnj closed 9 months ago
Excellent! ๐
Does this mean that we can now make https://github.com/cisagov/pre-commit-shfmt a public archive?
Yes that's the plan once this is merged.
Excellent! ๐ Does this mean that we can now make https://github.com/cisagov/pre-commit-shfmt a public archive?
Yes that's the plan once this is merged.
Great! You should add that as a post-merge checklist item so that we don't forget about it.
๐ฃ Description
This pull request switches the pre-commit hook used to run shfmt from cisagov/pre-commit-shfmt to scop/pre-commit-shfmt. It also updates the arguments to shfmt to use the long options that are now available.
๐ญ Motivation and context
The new hook actually bundles the binary releases from shfmt into a Python package that is used for the hook. This removes the need to have the shfmt tool installed before you are able to use the hook.
๐งช Testing
Automated tests pass.
โ Pre-approval checklist
โ Post-merge checklist