cisagov / skeleton-generic

A generic skeleton project for quickly getting a new cisagov project started.

Creative Commons Zero v1.0 Universal

14 stars 11 forks source link

Build Workflow Runs All Jobs Twice #174

Closed Matthew-Grayson closed 5 months ago

Matthew-Grayson commented 6 months ago

🐛 Summary

Creating a PR initiates two instances of each build job. 'Run diagnostics' and 'lint' both run twice. These are spawned by .github/workflows/build.yml.

jsf9k commented 6 months ago

This is intentional:

We need workflows to run on a push event so that testing happens on branches even before a PR is created.
We need workflows to run on a pull_request event. This is so that testing happens on branches created from forks of our repos when the forker creates a PR back to our repo to integrate his or her changes.