cisagov / skeleton-generic

A generic skeleton project for quickly getting a new cisagov project started.
Creative Commons Zero v1.0 Universal
14 stars 12 forks source link

Pin package for `ansible-lint` in `pre-commit` #180

Closed jsf9k closed 6 months ago

jsf9k commented 7 months ago

๐Ÿ—ฃ Description

This pull request pins ansible-core when running ansible-lint in pre-commit. It also adds a comment explaining why the Python package ansible may sometimes need to be added as an additional dependency for the ansible-lint linter in .pre-commit-config.yaml.

๐Ÿ’ญ Motivation and context

This is done to match the pinning that was done in cisagov/skeleton-ansible-role#193.

๐Ÿงช Testing

All automated tests pass.

โœ… Pre-approval checklist

jsf9k commented 6 months ago

We can close this pull request because a new version of the ansible-core Python package has been released that does not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy.