search

cisagov / tpt-reports

Process to build and distribute Technical Phishing Test (TPT) reports
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Validate DOMAIN_TESTED argument inputs #36

Closed schmelz21 closed 12 months ago

schmelz21 commented 1 year ago

💡 Summary

At a minimum, validate that the argument submitted that its syntax is a domain. Possibly consider the value of actually validating the domain entered existences.

Motivation and context

Validating DOMAIN_TESTED syntax improves quality control of the TPT report service and validating its existence and possibly gathering other relevant data may help improve upon the report content.

Implementation notes

Acceptance criteria

How do we know when this work is done?

schmelz21 commented 1 year ago

@jthough9 , @jennythompson8675309 , @MinaSalehi - We are looking for emails/domains to test against. Can any of you get a list of our Group 4 and share it in Teams.

jennythompson8675309 commented 1 year ago

Email addresses for Group 4 POCs shared in Teams.

schmelz21 commented 1 year ago

It was determined in PR https://github.com/cisagov/tpt-reports/pull/37 string validation for "email domain" is the only requirement at this time. Any "email domain" lookup service is considered out of scope.