Add validation for DOMAIN_TESTED argument

JCantu248 commented 1 year ago

🗣 Description

Add code to validate the DOMAIN_TESTED argument is a valid email domain.

💭 Motivation and context

This code will validate user input for sanity checks, to ensure the supplied email domain is in the correct format. This PR resolves issue https://github.com/cisagov/tpt-reports/issues/36

🧪 Testing

Testing on usage arguments, with valid and invalid email formatted string for DOMAIN_TESTED argument.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[x] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

schmelz21 commented 1 year ago

Requirement Update - It was determined that the argument is strictly an email domain, and does not necessarily linked to a web/request url. So the goal of this ticket is to create a validation on the string only.

dav3r commented 1 year ago

I see that you have linked this PR with issue #36. Typically, we also like to explicitly put something like "This PR resolves #36." in the PR's "Motivation and context" section above.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6199486455

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals
Change from base Build 6199482471:	0.0%
Covered Lines:	0
Relevant Lines:	0

💛 - Coveralls

dav3r commented 1 year ago

One thing I just noticed is that you have the checkbox for post-merge item "Create a release" checked. That shouldn't be checked yet since this PR hasn't been merged yet. Also, you have not been using bump_version.sh (or any other mechanism, but that is the easiest one) to manage the version string for this repo. Once you start doing that, then it will make sense for you to start creating releases after each PR is merged.

cisagov / tpt-reports