Convert OUTPUT_DIRECTORY to optional argument with default value

nickviola commented 11 months ago

🗣 Description

Resolves #27 and converts OUTPUT_DIRECTORY argument to optional "-o --output-dir" with default value decided by team. The default output directory has been set to "~/" (root of users home directory). This PR also patches generate_reports function in test_tpt_reports.py so that it doesn't actually generate pdfs in unit testing.

💭 Motivation and context

Closes #27, the result of planning discussions with the team to add versatility to the script and simplicity for users.

🧪 Testing

Run the command line tool without any output directory supplied to use the default "~/" or pass another directory with --output-dir=.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 6358242208

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals
Change from base Build 6357232685:	0.0%
Covered Lines:	0
Relevant Lines:	0

💛 - Coveralls

nickviola commented 11 months ago

Since this PR has already been approved, I will put the versioning changes in my next PR per discussions here: https://github.com/cisagov/tpt-reports/pull/51#issuecomment-1737566932

cisagov / tpt-reports