cisagov / tpt-reports

Process to build and distribute Technical Phishing Test (TPT) reports
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Update payloads_not_blocked to host_not_blocked in report_generator.py #67

Closed ameliav closed 12 months ago

ameliav commented 12 months ago

๐Ÿ—ฃ Description

Update payloads_not_blocked to host_not_blocked in report_generator.py

๐Ÿ’ญ Motivation and context

"We expected the total payloads executed value to match the total number of Not Blocked's in the Host Protection Column of the payloads." Found in issue #65

๐Ÿงช Testing

I created the report a few times with different input values to determine that the result matched.

๐Ÿ“ท Screenshots

The screenshot show that it is only capturing the total amount from host protection. image

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist

coveralls commented 12 months ago

Pull Request Test Coverage Report for Build 6734918259


Totals Coverage Status
Change from base Build 6549233012: 0.0%
Covered Lines: 0
Relevant Lines: 0

๐Ÿ’› - Coveralls
schmelz21 commented 12 months ago

FYI - as of now current report backlog = 8

schmelz21 commented 12 months ago

@dav3r or @jsf9k - either one of you able to take a look? It is a minor calculation change, and we have some reports on hold until we update. Thanks.