cisagov / tpt-reports

Process to build and distribute Technical Phishing Test (TPT) reports
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Update parsing logic to account for recent changes to input JSON file format. #69

Closed JCantu248 closed 11 months ago

JCantu248 commented 12 months ago

πŸ—£ Description

The RPT has updated the format of their JSON data that provides input to TPT-Reports. The source for TPT-Reports has been updated to reflect these changes. The payloads list has been nested under the phishing_assessment property. In addition, the assessment ID number is provided in the new format, so it is no longer necessary as a command line argument and has been removed.

All test cases have been updated to reflect these new changes. Resolves issue #66

πŸ’­ Motivation and context

This change is required so the PCA team can use TPT-Reports with the latest RPT JSON format.

πŸ§ͺ Testing

Test cases have been updated and verified with PyTest.

βœ… Pre-approval checklist

βœ… Pre-merge checklist

βœ… Post-merge checklist

coveralls commented 12 months ago

Pull Request Test Coverage Report for Build 6775873184


Totals Coverage Status
Change from base Build 6737391088: 0.0%
Covered Lines: 0
Relevant Lines: 0

πŸ’› - Coveralls