cisagov / trustymail

Scan domains and return data based on trustworthy email best practices
Creative Commons Zero v1.0 Universal
185 stars 31 forks source link

Switch helper package for the Public Suffix List #128

Closed mcdonnnj closed 1 year ago

mcdonnnj commented 1 year ago

๐Ÿ—ฃ Description

This pull request switches Public Suffix List helper packages from publicsuffix to publicsuffixlist. Any necessary supporting changes are also made.

๐Ÿ’ญ Motivation and context

The publicsuffix package is deprecated and has not been maintained for years. It finally reached a breaking point during this past weekend's BOD 18-01 scanning run where the server hosting the maintained public suffix list no longer returned the charset header that publicsuffix expects. The publicsuffixlist package is the currently maintained one of the two alternatives mentioned by publicsuffix and it has a compatibility layer for existing code that uses publicsuffix.

๐Ÿ”” See also

๐Ÿงช Testing

Automated tests pass. I confirmed that I was able to perform a local scan using this branch.

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist