search

cisagov / trustymail

Scan domains and return data based on trustworthy email best practices
Creative Commons Zero v1.0 Universal
185 stars 31 forks source link

Citing Obsolete SPF RFC 4408 vice Current RFC 7208 #136

Open chrislandis opened 1 year ago

chrislandis commented 1 year ago

I noticed in the documentation that it cites RFC 4408, which RFC 7208 has superseded. https://github.com/cisagov/trustymail/blob/585c9a8f8fa72a017b1f01070aa51d6f81f8b1f0/README.md?plain=1#L141-L142

I cannot find anywhere else in the project that cites RFC 4408, but RFC 7208 is cited in https://github.com/cisagov/trustymail/issues/7#issue-256903837 and https://github.com/cisagov/trustymail/issues/21#issuecomment-344039837. Comparing the trustymail code and these two RFCs, it seems that trustymail does not conflict with RFC 7208 and should cite it instead of RFC 4408.

If you would like, I can make this one-line change in the README and submit a pull request.

jsf9k commented 1 year ago

Thank you for the issue, @chrislandis!

Please feel free to go ahead and make the change to the README. While you're at it, we may as well make the RFC 7208 text link to the RFC as well.