The --psl-filename=FILENAME and --psl-read-only arguments are not working. The variables that get the values from the user's arguments are different from the variables that are used in get_psl function.
💭 Motivation and context
The arguments are not working when I assign the file path to public suffix list.
🧪 Testing
Run pip install git+https://github.com/stanley101music/trustymail@modify-psl-parameters
Run trustymail google.com
Confirm the default values are correct, and the public_suffix_list.dat are downloaded in the current folder
Change the filename of public_suffix_list.dat to exists_psl.dat
Change the last modified time of exists_psl.dat by touch -m exists_psl.dat
Run trustymail --psl-filename=exists_psl.dat google.com
Confirm that there is no need to call updatePSL
✅ Pre-approval checklist
[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
🗣 Description
The
--psl-filename=FILENAMEand--psl-read-onlyarguments are not working. The variables that get the values from the user's arguments are different from the variables that are used inget_pslfunction.💭 Motivation and context
The arguments are not working when I assign the file path to public suffix list.
🧪 Testing
pip install git+https://github.com/stanley101music/trustymail@modify-psl-parameterstrustymail google.compublic_suffix_list.datare downloaded in the current folderpublic_suffix_list.dattoexists_psl.datexists_psl.datbytouch -m exists_psl.dattrustymail --psl-filename=exists_psl.dat google.comupdatePSL✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist