cisagov / trustymail

Scan domains and return data based on trustworthy email best practices
Creative Commons Zero v1.0 Universal
189 stars 31 forks source link

Do not treat ambiguity as error #96

Closed jsf9k closed 5 years ago

jsf9k commented 5 years ago

Digging through the code of the SPF library we're using in trustymail (which was written by an author of the SPF RFC), I can confirm the following:

We have been treating these conditions as SPF errors, but it makes more sense to treat them as warnings. Therefore I modified the code so that it logs these conditions as warnings (so that they will appear in the CSV that is attached to the report) but does not label the SPF as "invalid" in response.

treas.gov is one host that was being incorrectly labeled as having invalid SPF, since is uses the mx mechanism but does not have any MX records.