cisagov / vulnrichment

A repo to conduct vulnerability enrichment.
Creative Commons Zero v1.0 Universal
462 stars 35 forks source link

Uniquify orgId and shortName #66

Closed shino closed 3 months ago

shino commented 3 months ago

๐Ÿ—ฃ Description

Fixes #63

There are two variants in providerMetadata's orgId/shortName fields. This PR uniquify them to

"shortName": "CISA-ADP", 
"orgId": "134c704f-9b21-4f2e-91b3-4a467353bcc0",

๐Ÿ’ญ Motivation and context

These fileds should be unique.

๐Ÿงช Testing

% find .  \( -name \*.json \) -print | xargs -P5 -I {} grep 'CISA-ADP' '{}' | wc -l
8613
% find .  \( -name \*.json \) -print | xargs -P5 -I {} grep '134c704f-9b21-4f2e-91b3-4a467353bcc0' '{}' | wc -l
8613
% find .  \( -name \*.json \) -print | xargs -P5 -I {} grep 'CISAADP' '{}' | wc -l
0
% find .  \( -name \*.json \) -print | xargs -P5 -I {} grep '8c464350-323a-4346-a867-fc54517fa145' '{}' | wc -l
0

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist

jwoytek-cisa commented 3 months ago

@shino Thank you for your report. This desynch was the result of the recent move to publish into ADP in CVE Services Production. The data had been fixed upstream but not all updates had made it here yet. These should be resolved today.

shino commented 3 months ago

@jwoytek-cisa Thanks for the comment. I'm happy that current HEAD has unique ID/name!