cisco-en-programmability / dnacentersdk

Cisco DNA Center Python SDK
https://dnacentersdk.readthedocs.io/en/latest/
MIT License
70 stars 33 forks source link

Constancy in "offset" and "limit" implementation by using datatype to be either "Int" or "string" #78

Closed ragadegithub closed 1 year ago

ragadegithub commented 1 year ago

Prerequisites

Describe the bug when using offset and limit for large API outputs, some methods in sdk are using "string" datatype for offset and others are using "int" data type example: api.devices.get_device_list( limit:int, offset: int)) api.tag.get_tag_members_by_id(tag_id, "networkdevice",offset:str ,limit:str )

Expected behavior Consistency in datatype for "offset" and "limit".

Screenshots Please provide an screenshot of the successful API call with cuRL, Postman, etc.

Environment (please complete the following information):

Additional context

bvargasre commented 1 year ago

Hi @ragadegithub dnacentersdk v2.5.6. is available. Offset and limit now support both string and int for Cisco DNA Center version 2.3.3.0. Feel free to test it and close or comment if necessary.

ragadegithub commented 1 year ago

verified the current requirement is available in dnacentersdk==2.5.6