cisco-en-programmability / terraform-provider-dnacenter

https://registry.terraform.io/providers/cisco-en-programmability/dnacenter/latest/docs
MIT License
14 stars 12 forks source link

Hardcoded sleep in `dnacenter_floor`, `dnacenter_building`, `dnacenter_area` resources #227

Closed mschedrin closed 1 year ago

mschedrin commented 1 year ago

Prerequisites

Describe the bug I noticed that deletion of dnacenter_floor resource is taking long time, looked at the resource code and found time.Sleep(1 * time.Minute) in resourceFloorDelete function. The same sleep can be found in _building and _area resources. Please remove it, I hope it is not necessary any more.

fmunozmiranda commented 1 year ago

Hi @mschedrin, problem we are working to remove it, tommorow a new version will be released.

mschedrin commented 1 year ago

@fmunozmiranda you have removed delay in building resource, but forgot to do the same for area: https://github.com/cisco-en-programmability/terraform-provider-dnacenter/blob/860d4589a2bbaa683f3649f80c38579e0d3e2e1d/dnacenter/resource_area.go#L408 and floor: https://github.com/cisco-en-programmability/terraform-provider-dnacenter/blob/860d4589a2bbaa683f3649f80c38579e0d3e2e1d/dnacenter/resource_floor.go#L568

fmunozmiranda commented 1 year ago

Sleeps removed.