search

cisco-ie / pipeline-gnmi

A Model-Driven Telemetry collector based on the open-source tool pipeline
Apache License 2.0
32 stars 6 forks source link

Remove Go module files #34

Closed remingtonc closed 5 years ago

remingtonc commented 5 years ago

Removing go.mod and go.sum per comments. Also related to #5 and the ongoing jsonpb issues.

@nleiva as someone who is contributing a bit, simply made you a contributor to keep it easy.

nleiva commented 5 years ago

Instead of removing them, we might want to replace them for the correct ones (so we support Go 1.12+). In order to generate them, execute this go mod init github.com/cisco-ie/pipeline-gnmi at the root of the repo. It will add a new go.mod and go.sum.

remingtonc commented 5 years ago

My current problem is that when building with Go modules there are multiple failures with jsonpb. Not using Go modules still works exclusively because the vendor/ed code itself contains the patch. We are inherently broken here the moment we stop using vendor. Can test from go-modules branch and set GO111MODULE=on in docker/Dockerfile.

nleiva commented 5 years ago

Thanks for the branch, I’ll work on it next week. I’ll keep you posted.

BenderScript commented 5 years ago

We should definitely have a separate branch for that. The transition to Go mod should be very smooth and thoroughly tested (lots of Stackoverflow horror stories). We should test building outside the GOPATH in a fresh install. As soon as @remingtonc get Travis running on the repo we can hopefully created a new Go Mod job.