search

cisco-ie / pipeline-gnmi

A Model-Driven Telemetry collector based on the open-source tool pipeline
Apache License 2.0
32 stars 6 forks source link

Build MacOS, Linux, and Windows #52

Closed remingtonc closed 5 years ago

remingtonc commented 5 years ago

make build now refers to make hygiene, make darwin/amd64, make linux/amd64, and make windows/amd64. The individual builds are controlled by the PLATFORMS variable - I could not determine how to effectively document them in make help. Resolves #14

BenderScript commented 5 years ago

Need to create travis jobs for the other OSs

On May 31, 2019, at 10:39 AM, Remington Campbell notifications@github.com wrote:

make build now refers to make hygiene, make darwin/amd64, make linux/amd64, and make windows/amd64. The individual builds are controlled by the PLATFORMS variable - I could not determine how to effectively document them in make help.

You can view, comment on, or merge this pull request online at:

https://github.com/cisco-ie/pipeline-gnmi/pull/52

Commit Summary

Build MacOS, Linux, and Windows File Changes

M skeleton/pipeline.mk (22) Patch Links:

https://github.com/cisco-ie/pipeline-gnmi/pull/52.patch https://github.com/cisco-ie/pipeline-gnmi/pull/52.diff — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

remingtonc commented 5 years ago

make build will build them all by default. To get more specific we can enter make linux/amd64 etc.

remingtonc commented 5 years ago

e.g. https://travis-ci.org/cisco-ie/pipeline-gnmi/jobs/539816270#L604

BenderScript commented 5 years ago

thanks for the cross compile, but the tests are running only for Ubuntu/Linux, correct?

remingtonc commented 5 years ago

Yes they only run on Linux but cross-compile for building. Given we don't have any platform-dependent functionality - do we need to test on each individual OS?

BenderScript commented 5 years ago

Protobufs themselves are platform dependent given it is heavily reliant on OS stack specifics. I would at least add to the README that windows support is experimental.

I am not sure any of us have actually tried to run pipeline on windows? To that effect, there are quite a few of windows variants.