Update k8s dependencies to 0.17.4

cisco-open / k8s-objectmatcher

A Kubernetes object matcher library to avoid unnecessary K8s object updates

Apache License 2.0

157 stars 29 forks source link

Update k8s dependencies to 0.17.4 #25

Closed amuraru closed 4 years ago

amuraru commented 4 years ago

Q	A
Bug fix?	no
New feature?	yes
API breaks?	no
Deprecations?	no
License	Apache 2.0

What's in this PR?

Update k8s dependencies to v0.17.4

Why?

Ability to integrate this lib in go projects using newer version of k8s

Checklist

[x] Implementation tested
[n/a] Error handling code meets the guideline
[n/a] Logging code meets the guideline
[n/a] User guide and development docs updated (if needed)

amuraru commented 4 years ago

@pepov @baluchicken i see this fails under k8s 1.17 I know that kafka-operator just upgraded its deps to 1.17 and making use of this library. Can this pose any issue there? Thanks

pepov commented 4 years ago

@amuraru I beleive no. The mutatingwebhook failure is a test for legacy k8s versions, I think that just need to be skipped for 1.7.

I will have to look into the other one, but does kafka-operator use statefulsets for anything?

amuraru commented 4 years ago

@pepov thanks for looking into that. Disabled the webhooks check for 1.17 but the volumeClaim check still fails. Kafka-operator is not using StS but is using PVCs so wonderinf if this is actually a real issue. /cc @baluchicken

pepov commented 4 years ago

PVC in STS is special since it embeds a full object instead of a spec, we already had a lot of issues around this. I couldn't reproduce the issue locally on a 1.17 cluster and didn't understood the diff that objectmatcher reported but will get back to this.

pepov commented 4 years ago

I mean issues around the objectmatcher reporting a diff, which should be the better case. (worst case would be to hide a potential diff)

pepov commented 4 years ago

closing in favour of #26 which contains @amuraru initial attempt and extends it to support proper sts diffs on v1.17.4 and up