First iteration to fix and test issues with service and pod matchers - Githubissues

cisco-open / k8s-objectmatcher

A Kubernetes object matcher library to avoid unnecessary K8s object updates

Apache License 2.0

157 stars 29 forks source link

First iteration to fix and test issues with service and pod matchers #3

Closed pepov closed 5 years ago

pepov commented 5 years ago

Q	A
Bug fix?	yes
New feature?	no
API breaks?	no
Deprecations?	no
License	Apache 2.0

What's in this PR?

Some bug fixes for the pod and service matchers and integration tests to verify the changes:

always deepcopy incoming objects because we cannot really trust clients to do it for us
run default field decorator functions on the local (new) objects before matching (adds https://github.com/kubernetes/kubernetes as a dependency)
ignore generated NodePort in Service Ports
ignore EnableServiceLinks for Pod Spec when it's not set on either objects (it was only introduced in 1.13, so it's not present in 1.12)

Also the PR adds a CircleCI setup to check for compatibility against Kubernetes server versions 1.12,1.13,1.14

https://circleci.com/gh/pepov/k8s-objectmatcher

Checklist

[x] Implementation tested
[ ] Error handling code meets the guideline

To Do

[ ] Add more test data to cover edge cases where needed
[ ] Add more integration tests to cover all the matchers and fix any arising issues