feat: add repeated test in http ping agent plugin - Githubissues

cisco-open / synthetic-heart

Kubernetes synthetic testing and monitoring framework

Apache License 2.0

8 stars 6 forks source link

feat: add repeated test in http ping agent plugin #17

Closed lunzhou2024 closed 2 months ago

lunzhou2024 commented 4 months ago

Description

in agent plugin: httpPing add two config params: repeatsWithoutFail and waitBetweenRepeats

repeatsWithoutFail is the total repeated http ping test times. If any failure occurs, the final test result will be failed. It conflicts with retries and timeoutRetries.
no change to current logic of retries and timeoutRetries.

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[x] New code contribution is covered by automated tests
[x] All new and existing tests pass

bakshi41c commented 4 months ago

Can we also add a warning log, if the test is configured to use both retries/timeoutRetries and the new options

lunzhou2024 commented 2 months ago

Can we also add a warning log, if the test is configured to use both retries/timeoutRetries and the new options

https://github.com/cisco-open/synthetic-heart/pull/17/files#diff-817f7fbcc0100f55117ac3b2988d6fdc8893eda0d48cb6c60ffd6c5f2deae5d2R80