search

cisco-open / terraform-provider-meraki

A Terraform Provider for Cisco Meraki
Mozilla Public License 2.0
17 stars 7 forks source link

Delete function for layer 3 firewall rules #164

Closed yujiterada closed 1 month ago

yujiterada commented 1 month ago

Is your feature request related to a problem? Please describe. Since delete function for layer 3 firewall rules does not exist,

  1. "terrafrom destroy" sometimes fails
  2. not great from a management perspective when configuring layer 3 firewall rules via Terrafom.

Describe the solution you'd like Properly code below in ./internal/provider/resource_meraki_networks_appliance_firewall_l3_firewall_rules.go

func (r *NetworksApplianceFirewallL3FirewallRulesResource) Delete(ctx context.Context, req resource.DeleteRequest, resp *resource.DeleteResponse) {
    //missing delete
    resp.Diagnostics.AddWarning("Error deleting NetworksApplianceFirewallL3FirewallRules", "This resource has no delete method in the meraki lab, the resource was deleted only in terraform.")
    resp.State.RemoveResource(ctx)
}

Describe alternatives you've considered Removing configuration from Dashboard

Additional context Will try to create a pull request