search

cisco-open / terraform-provider-meraki

A Terraform Provider for Cisco Meraki
Mozilla Public License 2.0
15 stars 6 forks source link

Multiple features failing terratest idempotent test #83

Closed kempy007 closed 1 month ago

kempy007 commented 2 months ago

Prerequisites

Describe the bug

Idempotent tests are failing in terratest.

--- FAIL: Test_Meraki_Provider (329.82s) --- PASS: Test_Meraki_Provider/vmx_network (16.24s) --- PASS: Test_Meraki_Provider/claim_vmx (18.99s) --- FAIL: Test_Meraki_Provider/inbound_firewall_rules (9.68s) --- PASS: Test_Meraki_Provider/firewall_l3_rules (20.68s) --- PASS: Test_Meraki_Provider/syslog_servers (18.32s) --- PASS: Test_Meraki_Provider/webhooks_http (19.26s) --- PASS: Test_Meraki_Provider/data_meraki_devices (19.25s) --- PASS: Test_Meraki_Provider/data_firmware_upgrades (19.79s) --- PASS: Test_Meraki_Provider/meraki_device_name (22.59s) --- PASS: Test_Meraki_Provider/meraki_device_tag (21.61s) --- PASS: Test_Meraki_Provider/vmx_authentication_token (17.91s) --- PASS: Test_Meraki_Provider/single_lan (20.73s) --- FAIL: Test_Meraki_Provider/alert_settings (17.98s) --- FAIL: Test_Meraki_Provider/vpn_firewall_rules (33.93s) --- FAIL: Test_Meraki_Provider/third_party_vpnpeers (4.11s) --- PASS: Test_Meraki_Provider/data_meraki_networks (10.25s) --- FAIL: Test_Meraki_Provider/firware_upgrades (13.88s) --- PASS: Test_Meraki_Provider/vpn_site_to_site (24.57s) FAIL exit status 1 FAIL test.com/m/v2 330.306s

To Reproduce export MERAKI_DASHBOARD_API_KEY= clone https://github.com/kempy007/terratest-terraform-provider-meraki rename test.tfvars.example to test.tfvars and update the org-id go test -v -timeout 10m

Expected behavior All the test should pass.

Versions

kempy007 commented 2 months ago

@fmunozmiranda can you please review

obrigg commented 2 months ago

Thank you for reporting these idempotency gaps. We are aware some of our API operations are not idempotent (mostly legacy operations). Yet idempotency does not justify a breaking change to the API operation itself. Due to the behavior of the specific API operations, we won't be able to make them idempotent in Terraform.

kempy007 commented 2 months ago

Thank you for reporting these idempotency gaps. We are aware some of our API operations are not idempotent (mostly legacy operations). Yet idempotency does not justify a breaking change to the API operation itself. Due to the behavior of the specific API operations, we won't be able to make them idempotent in Terraform.

How can I find out which ones do not support idempotentency?

fmunozmiranda commented 2 months ago

Actually, we have this ones documented, with the attrs that are not idempotent: 

meraki_networks_alerts_settings -> alerts
meraki_networks_appliance_content_filtering -> blocked_url_categories
meraki_networks_appliance_firewall_inbound_firewall_rules -> rules
meraki_networks_appliance_firewall_l3_firewall_rules -> rules
meraki_networks_appliance_firewall_l7_firewall_rules -> rules
meraki_networks_appliance_ssids -> radius_servers
meraki_networks_sensor_alerts_profiles -> conditions
meraki_networks_switch_access_control_lists -> rules
meraki_networks_switch_access_policies -> radius_accounting_servers, radius_servers
meraki_networks_switch_stp -> stp_bridge_priority
meraki_networks_wireless_ssids_firewall_l3_firewall_rules -> rules
meraki_networks_wireless_ssids -> radius_accounting_servers, radius_servers
meraki_organizations_appliance_vpn_third_party_vpnpeers -> peers

They may increase depending on what is detected through use of the provider.

fmunozmiranda commented 1 month ago

Closed due inactivity