cisco-sbg-ui / atomic-react

https://atomic-react.security.cisco.com
2 stars 5 forks source link

fix: Pagination pages incorrect when total=[7..11] #1175

Closed paulmach closed 2 years ago

paulmach commented 2 years ago

Fixes https://github.com/cisco-sbg-ui/atomic-react/issues/1173

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? Fixes the pagination when total=[7..11]

What is the current behavior? See https://github.com/cisco-sbg-ui/atomic-react/issues/1173

Screen Shot 2022-03-21 at 8 36 24 AM

What is the new behavior (if this is a feature change)?

If the current page is within 5 of the end, the mid section will be extended to the end. Previously this was not happening properly for the "end section".

Does this PR introduce a breaking change? No

Other information:

Question: how do I add a test? do I just created a "usage 4" in the pagination section?

vercel[bot] commented 2 years ago

@paulmach is attempting to deploy a commit to the Cisco SecureX Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/securex/atomic-react/FaaoiEkDZ7LR4bxurNafXkcoYJ2L
✅ Preview: https://atomic-react-git-fork-paulmach-pagination-securex.vercel.app