cisco-sbg-ui / atomic-react

https://atomic-react.security.cisco.com

2 stars 5 forks source link

fix: allow overflow styling for ASelect dropdown menu #1178

Closed brennarvo closed 2 years ago

brennarvo commented 2 years ago

Please check if the PR fulfills these requirements

[ ] The commit message follows semantic commit message guidelines
[ ] The changes are documented in component docs and changelog
[ ] The ESLint plugin has been updated if a new component is added
[ ] Test have been added or modified, if appropriate
[ ] Has been verified locally

What kind of change does this PR introduce?

Resolves #1176

What is the current behavior?

The ASelect component hides dropdown selections from being shown if there are too many selections to fit in the viewport.

What is the new behavior (if this is a feature change)?

Adds an overflow property on the selection wrapper if the maxHeight property is passed
Updates a querySelector call to correctly grab the proper element to focus to when opening the dropdown

Does this PR introduce a breaking change?

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/securex/atomic-react/7yXordmHwkYVHNHi7nFSvAvFoZTV
✅ Preview: https://atomic-react-git-fix-select-overflow-securex.vercel.app

codecov[bot] commented 2 years ago

Codecov Report

Merging #1178 (26c3b18) into master (d3bc339) will increase coverage by 0.09%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   90.37%   90.46%   +0.09%     
==========================================
  Files          98       98              
  Lines        3054     3053       -1     
  Branches     1043     1044       +1     
==========================================
+ Hits         2760     2762       +2     
+ Misses        253      250       -3     
  Partials       41       41

Impacted Files	Coverage Δ
framework/components/ASelect/ASelect.js	`95.43% <100.00%> (+1.49%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3bc339...26c3b18. Read the comment docs.