cisco-sbg-ui / atomic-react

https://atomic-react.security.cisco.com
2 stars 5 forks source link

docs(ADataTable): clarify onScrollToEnd prop invocation #1194

Closed brennarvo closed 2 years ago

brennarvo commented 2 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

Documents the behavior of the onScrollToEnd prop inside ADataTable.

What is the current behavior?

The docs do not mention that onScrollToEnd is called only for the initial scroll to the bottom of the table.

What is the new behavior (if this is a feature change)?

Clarifies that onScrollToEnd only fires when the user first reaches the bottom of the table.

Does this PR introduce a breaking change?

No

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/securex/atomic-react/CeGwpGX2emPHgP6MKZxkg5xL8xeV
✅ Preview: https://atomic-react-git-docs-infinite-scroll-securex.vercel.app

codecov[bot] commented 2 years ago

Codecov Report

Merging #1194 (f098594) into master (d3ecaba) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1194   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files          98       98           
  Lines        3056     3056           
  Branches     1045     1045           
=======================================
  Hits         2765     2765           
  Misses        250      250           
  Partials       41       41           
Impacted Files Coverage Δ
framework/components/ADataTable/ADataTable.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3ecaba...f098594. Read the comment docs.