cisco-sbg-ui / atomic-react

https://atomic-react.security.cisco.com
2 stars 5 forks source link

Type letter to focus menu item for ASelect #997 #1219

Open BogdanV3 opened 2 years ago

BogdanV3 commented 2 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? feature

Closes #997

What is the current behavior?

What is the new behavior (if this is a feature change)? Focus on the first item that begins with user typed characters.

Does this PR introduce a breaking change? No

Other information:

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
atomic-react ✅ Ready (Inspect) Visit Preview May 23, 2022 at 1:44PM (UTC)
codecov[bot] commented 2 years ago

Codecov Report

Merging #1219 (d2db7c4) into master (a50b971) will decrease coverage by 0.25%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   91.20%   90.95%   -0.26%     
==========================================
  Files         104      104              
  Lines        3162     3174      +12     
  Branches     1054     1056       +2     
==========================================
+ Hits         2884     2887       +3     
- Misses        240      248       +8     
- Partials       38       39       +1     
Impacted Files Coverage Δ
framework/components/AMenu/AMenu.js 85.29% <25.00%> (-12.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a50b971...d2db7c4. Read the comment docs.

BogdanV3 commented 2 years ago

@brennarvo, if you got some time, please have a look. After the code review, I can move further to fix the tests. Also: https://github.com/cisco-sbg-ui/atomic-react/pull/1216

BogdanV3 commented 2 years ago

@brennarvo reminder :)