search

cisco-system-traffic-generator / trex-core

trex-core site
https://trex-tgn.cisco.com/
Other
1.3k stars 462 forks source link

ASTF acquire command is clearing just loaded profiles and topology #952

Open jsmoon opened 1 year ago

jsmoon commented 1 year ago

Hi, recently I found that the following code in ASTF "acquire" command clears just loaded profiles and topology. https://github.com/cisco-system-traffic-generator/trex-core/blob/26e9aa98a242e6fce5c6bef0ea2b92c1a0b50367/src/stx/astf/trex_astf_rpc_cmds.cpp#L193-L209 I did not expect this behavior before, because I thought the "acquire" would get server ownership only. Is there any reason to do this? I think the loaded profiles and topology should be kept also like the already parsed profiles and topology. @hhaim, what do you think about it?

hhaim commented 1 year ago

@jsmoon if the state was changed from "not_acquire" > "acquire" you can't keep the old user profiles and data.

jsmoon commented 1 year ago

@hhaim but already parsed profiles are kept. And I think cleaning up old user profiles and data can be done separately after acquisition.

jsmoon commented 1 year ago

@hhaim please review my comment again. There is an inconsistency between the run profile (keep) and the loaded profile (clear).