search

cisco / ChezScheme

Chez Scheme
Apache License 2.0
6.95k stars 982 forks source link

repair for overflow checking and `raw` form #699

Closed mflatt closed 1 year ago

mflatt commented 1 year ago

In 102b2c1082, the auto-generated case in np-place-overflow-and-trap for raw was not the correct treatment of the form.

jltaylor-us commented 1 year ago

Can confirm that, at optimize-level 3, the expression added in the mats errors (specifically with Exception: illegal instruction. Some debugging context lost on my system) on the code in main and works as expected with single line addition from this PR.

I'm not familiar with this bit of code, so I guess I'll give it a day or two to make sure nobody else wants to raise any objection or issue.

owaddell commented 1 year ago

Great find, Matthew. Thanks for the fix!